update to SourceLink 1.0 #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,12 +65,11 @@ NUGET | |||
| Nancy (>= 1.2.0) | |||
| Newtonsoft.Json (6.0.8) | |||
| NuGet.CommandLine (2.8.5) | |||
| Nuget.Core (2.8.5) | |||
| NuGet.Core (2.8.5) | |||
There was a problem hiding this comment.
It this really causing a Travis build failure. Yikes. That is the real name of the package and is what Paket-Install 1.18.0 set it to.
|
:-) |
| proj.CreateSrcSrv (sprintf "%s/%s/{0}/%%var2%%" gitRaw projectName) repo.Commit (repo.Paths files) | ||
| Pdbstr.exec proj.OutputFilePdb proj.OutputFilePdbSrcSrv | ||
| let url = sprintf "%s/%s/{0}/%%var2%%" gitRaw projectName | ||
| proj.SourceIndex proj.OutputFilePdb proj.CompilesNotLinked __SOURCE_DIRECTORY__ url |
There was a problem hiding this comment.
I think this will be a lot more straightforward for people.
| Pdbstr.exec proj.OutputFilePdb proj.OutputFilePdbSrcSrv | ||
| ) | ||
| let url = sprintf "%s/%s/{0}/%%var2%%" gitRaw projectName | ||
| SourceLink.Index proj.CompilesNotLinked proj.OutputFilePdb __SOURCE_DIRECTORY__ url ) |
There was a problem hiding this comment.
This feels much nicer!
|
is it ready to merge? |
|
Ready to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on SourceLink 0.6. @forki logged ctaggart/SourceLink#45 that I'm going to try to address here. This isn't to be merged until I release 0.6. Ideally this coming week.