-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to SourceLink 1.0 #845
Conversation
@@ -65,12 +65,11 @@ NUGET | |||
Nancy (>= 1.2.0) | |||
Newtonsoft.Json (6.0.8) | |||
NuGet.CommandLine (2.8.5) | |||
Nuget.Core (2.8.5) | |||
NuGet.Core (2.8.5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It this really causing a Travis build failure. Yikes. That is the real name of the package and is what Paket-Install 1.18.0 set it to.
proj.CreateSrcSrv (sprintf "%s/%s/{0}/%%var2%%" gitRaw projectName) repo.Commit (repo.Paths files) | ||
Pdbstr.exec proj.OutputFilePdb proj.OutputFilePdbSrcSrv | ||
let url = sprintf "%s/%s/{0}/%%var2%%" gitRaw projectName | ||
proj.SourceIndex proj.OutputFilePdb proj.CompilesNotLinked __SOURCE_DIRECTORY__ url |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will be a lot more straightforward for people.
Pdbstr.exec proj.OutputFilePdb proj.OutputFilePdbSrcSrv | ||
) | ||
let url = sprintf "%s/%s/{0}/%%var2%%" gitRaw projectName | ||
SourceLink.Index proj.CompilesNotLinked proj.OutputFilePdb __SOURCE_DIRECTORY__ url ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels much nicer!
is it ready to merge? |
Ready to merge now. |
I'm working on SourceLink 0.6. @forki logged ctaggart/SourceLink#45 that I'm going to try to address here. This isn't to be merged until I release 0.6. Ideally this coming week.