You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Basically RazorEngine was leaking temp files sine 3.5.0. Now I have a fix/workaround in place but it only works when RazorEngine is not used in the default AppDomain. So we need to take additional actions here in F# Formatting (because the primary usage is via FSI, which sadly uses the default AppDomain..).
Because spinning up AppDomains in F# scripts will be very difficult (to get a dynamic assembly from one into another AppDomain), I can only see two options:
Spin up the AppDomain internally in F# Formatting (if we are in the default AppDomain)
But I guess this is only possible for high level APIs like MetadataFormat.Generate (I don't think we can support high order functions)
IMHO we should opt for 2 (it should be easier to implement as well) and leave F# Formatting unchanged, however I would like to hear what you think.
/cc @tpetricek@forki
The text was updated successfully, but these errors were encountered:
matthid
added a commit
to matthid/FSharp.Formatting
that referenced
this issue
Mar 27, 2015
Some background: Antaris/RazorEngine#244
Basically RazorEngine was leaking temp files sine 3.5.0. Now I have a fix/workaround in place but it only works when RazorEngine is not used in the default
AppDomain
. So we need to take additional actions here in F# Formatting (because the primary usage is via FSI, which sadly uses the default AppDomain..).Because spinning up AppDomains in F# scripts will be very difficult (to get a dynamic assembly from one into another AppDomain), I can only see two options:
But I guess this is only possible for high level APIs like
MetadataFormat.Generate
(I don't think we can support high order functions)Of course we need to also change https://github.com/fsprojects/ProjectScaffold/blob/master/build.template#L199 and spin up another FAKE process instead of calling
fsi.exe
.At this point everything should work fine.
IMHO we should opt for 2 (it should be easier to implement as well) and leave F# Formatting unchanged, however I would like to hear what you think.
/cc @tpetricek @forki
The text was updated successfully, but these errors were encountered: