Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of fixes to reference docs generation of latest FSharp.Data #223

Merged
merged 4 commits into from
Dec 30, 2014

Conversation

ovatsus
Copy link

@ovatsus ovatsus commented Nov 1, 2014

No description provided.

@ovatsus
Copy link
Author

ovatsus commented Nov 25, 2014

ping

@tpetricek
Copy link
Member

Sorry for the delay - the changes look good.

Could you explain why we need try .. with _ -> ...? I suspect there is a good reason for this, but as this is an anti-pattern (in general), it would be good to clarify this in a comment.

tpetricek added a commit that referenced this pull request Dec 30, 2014
Couple of fixes to reference docs generation of latest FSharp.Data
@tpetricek tpetricek merged commit 63493e7 into fsprojects:master Dec 30, 2014
@ovatsus
Copy link
Author

ovatsus commented Dec 31, 2014

To improve C# support, both XmlDocSig and TryFullName are now called (#217), but there was a FCS bug that caused TryFullName to blow up for type providers (fsharp/fsharp-compiler-docs#249). Once Fsharp.Formatting moves to newer FCS the try/with can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants