Update build script to run tests, updating packages.

[rachelblasucci]

I wasn't able to run the tests when I forked, so I upgraded to NUnit3, and then moved FsUnit to be grabbed from paket.

I'm still getting errors running the tests (below) but the project builds, and I thought I'd send over this progress. Thoughts? Either on how to fix the below, or the updates I've added?

Thanks!

1. System.Exception: Start of process failed. Cannot start process because a file name has not been provided.
   at Fake.ProcessHelper.ExecProcessWithLambdas@79-16.Invoke(String message) in C:\code\FAKE\src\app\FakeLib\ProcessHelper.fs:line 79
   at Fake.ProcessHelper.ExecProcessWithLambdas(FSharpFunc2 configProcessStartInfoF, TimeSpan timeOut, Boolean silent, F SharpFunc2 errorF, FSharpFunc2 messageF) in C:\code\FAKE\src\app\FakeLib\ProcessHelper.fs:line 79 at Fake.Testing.NUnit3.NUnit3(FSharpFunc2 setParams, IEnumerable1 assemblies) in C:\code\FAKE\src\app\FakeLib\UnitTe st\NUnit\NUnit3.fs:line 280 at FSI_0005.Build.clo@179-18.Invoke(Unit unitVar0) at Fake.TargetHelper.runSingleTarget(TargetTemplate1 target) in C:\code\FAKE\src\app\FakeLib\TargetHelper.fs:line 492

[rachelblasucci]

@forki I'm not sure if this is actually a FAKE thing or maybe just an interaction between the two, but thought you might know more about what's going wrong. Any ideas? :-) Thanks!

[forki]

can you please ask on twitter? I'm not an expert on NUnit3 - but I'm sure we'll find one

[tpetricek]

Thanks a lot for looking into this - updating to NUnit 3 would be great :)

[tpetricek]

I think we might actually need this file (for a release or something?), though I do not remember the details. /cc @matthid who probably knows more.... I think there was some intricate reason why the file had to be in this particular folder, even though it's not a normal place where we would put it.

[matthid]

Yep, it's there for bootstrapping reasons. Without this the build fails for multiple reasons:

• The file is no longer found when creating the nuget package
• The bootstrapping sanity check will no longer work

For now the build fails at an earlier point...

[rachelblasucci]

Ahh, I suspect it was deleted for me and then not re-generated? I'll add it back. :-)

[rachelblasucci]

Sooo, question. How important is setting the FSharp.Compiler.Service version in the paket.dependencies file? Is that what's causing this error? (It's at least different than the issue listed in Issue 277?) :-)

Error:
System.Exception: Could not detect package version for FSharp.Compiler.Service ---> System.Exception: Package FSharp.Compiler.Service was not found.
at Fake.NuGetHelper.version@113.Invoke(String message) in C:\code\FAKE\src\app\FakeLib\NuGet\NugetHelper.fs:line 113
at Fake.NuGetHelper.GetPackageVersion(String deploymentsDir, String package) in C:\code\FAKE\src\app\FakeLib\NuGet\NugetHelper.fs:line 113
--- End of inner exception stack trace ---
at Fake.NuGetHelper.GetPackageVersion(String deploymentsDir, String package) in C:\code\FAKE\src\app\FakeLib\NuGet\NugetHelper.fs:line 127
at FSI_0005.Build.replacements@88.Invoke(String packageName) in Y:\Projects\FSharp.Formatting\build.fsx:line 89
at Microsoft.FSharp.Collections.IEnumerator.map@111.DoMoveNext(b& )
at Microsoft.FSharp.Collections.IEnumerator.MapEnumerator1.System-Collections-IEnumerator-MoveNext() at Microsoft.FSharp.Collections.SeqModule.Fold[T,TState](FSharpFunc2 folder, TState state, IEnumerable1 source) at FSI_0005.Build.clo@85-12.Invoke(Unit _arg3) in Y:\Projects\FSharp.Formatting\build.fsx:line 95 at Fake.TargetHelper.runSingleTarget(TargetTemplate1 target) in C:\code\FAKE\src\app\FakeLib\TargetHelper.fs:line 492
System.Exception: Could not detect package version for FSharp.Compiler.Service ---> System.Exception: Package FSharp.Compiler.Service was not found.
at Fake.NuGetHelper.version@113.Invoke(String message) in C:\code\FAKE\src\app\FakeLib\NuGet\NugetHelper.fs:line 113
at Fake.NuGetHelper.GetPackageVersion(String deploymentsDir, String package) in C:\code\FAKE\src\app\FakeLib\NuGet\NugetHelper.fs:line 113
--- End of inner exception stack trace ---
at Fake.NuGetHelper.GetPackageVersion(String deploymentsDir, String package) in C:\code\FAKE\src\app\FakeLib\NuGet\NugetHelper.fs:line 127
at FSI_0005.Build.replacements@88.Invoke(String packageName) in Y:\Projects\FSharp.Formatting\build.fsx:line 89
at Microsoft.FSharp.Collections.IEnumerator.map@111.DoMoveNext(b& )
at Microsoft.FSharp.Collections.IEnumerator.MapEnumerator1.System-Collections-IEnumerator-MoveNext() at Microsoft.FSharp.Collections.SeqModule.Fold[T,TState](FSharpFunc2 folder, TState state, IEnumerable1 source) at FSI_0005.Build.clo@85-12.Invoke(Unit _arg3) in Y:\Projects\FSharp.Formatting\build.fsx:line 95 at Fake.TargetHelper.runSingleTarget(TargetTemplate1 target) in C:\code\FAKE\src\app\FakeLib\TargetHelper.fs:line 492

I was able to get around the previous issues after running a paket simplify which removed the FSharp.Compiler from paket.dependencies (not pushed yet here), but now I'm seeing that error when (GetPackageVersion "packages" packageName) is called in the UpdateFsxVersions target. I could be heading down totally the wrong path :-) but figured I'd ask.

[rachelblasucci]

@tpetricek: This shows as still breaking, but locally this builds entirely for me now. Any idea how to fix travis? :-)

[tpetricek]

I think this has been broken for some time - thanks for the nudge to fix that. With a bit of luck, #418 will fix that....

[tpetricek]

It worked! If you import latest changes in master into your PR, it should run.

[rachelblasucci]

Woohoo! Then if/when this looks good to you, it's ready to be merged. :-)

[tpetricek]

@matthid Could you have a quick look? You know some of the more intricate things that can go wrong here :)

[matthid]

Can we leave this line? It makes the file easier editable in Visual Studio.

[matthid]

Yeah looks good to me. I have marked some places regarding our most loved dependency "FSharpVSPowerTools"...

The cange in the solution file is not a stopper as it is easily added again.

[tpetricek]

Should I merge this into v3 and release a new beta, so that we can test it?

[rachelblasucci]

That would be awesome, assuming no one else has objections. :-)

[matthid]

Apparently now obsoleted by #430.
Sorry for not merging for sooooo long ...