Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages update #441

Closed
wants to merge 3 commits into from
Closed

packages update #441

wants to merge 3 commits into from

Conversation

dsyme
Copy link
Contributor

@dsyme dsyme commented Jun 28, 2017

A packages update and removes dependency on System.ValueTuple now FCS doesn't require it

@kurtschelfthout
Copy link
Contributor

Bump.

@matthid
Copy link
Member

matthid commented Sep 2, 2017

Oh, somehow I did miss this one. I think the URL changes are still relevant, the rest are only updates by paket, correct?

@kurtschelfthout
Copy link
Contributor

Yes, it looks like it - changes in fs files for the URLs and one in build.fsx to remove dep on ValueTuple. Other stuff is hopefully just the result of paket update.

I think there's also some manual changes to AssemblyInfos that should probably be driven from the release notes version instead in this PR.

@matthid
Copy link
Member

matthid commented Sep 2, 2017

Yes AssemblyInfos are automatically generated by FAKE. I'd love to see an update for this. Sorry for my total failure and missing it.

@matthid
Copy link
Member

matthid commented Sep 2, 2017

@kurtschelfthout Could you help out?

@kurtschelfthout
Copy link
Contributor

I'll try later, but not right now :). I tried using this package from the appveyor build to see if it fixes things but didn't get it to work yet ;)

@kurtschelfthout
Copy link
Contributor

Between the API changes in 3.0 and FSharp.Core and possibly all the rest of the netcore changes I have been unable to get this to work. It keeps telling me it's missing type Attribute or some such. Sigh.

I'm really short on patience right now having just gone through all that with trying to get literally every other tool I use in FsCheck so I'm bowing out here. Sorry, it's not your fault but it makes me really grumpy.

@matthid
Copy link
Member

matthid commented Sep 2, 2017

It probably IS my fault as I introduced the breaking API change:

Sorry for that.

Yes I'll take a look eventually, but this repository is quite low on my priority list at the moment (there is just too much other stuff)

@kurtschelfthout
Copy link
Contributor

No worries, no one has complained about the lack of tooltips in the docs yet ;)

@realvictorprm
Copy link

Still valid?

@matthid
Copy link
Member

matthid commented Feb 4, 2018

We merged the relevant changes, thanks to @wallymathieu

@matthid matthid closed this Feb 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants