Bump to FCS 40 #682
Merged
Bump to FCS 40 #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
approved these changes
Jul 22, 2021
|
That would be fine with me! I promise to use my powers only for good. My main use case is probably going to be FCS bumps to enable FSAC, so I don't plan on going crazy with foundational redesigns or anything :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates FCS to version 40, partially because we in FSAC use FSharp.Formatting internally so we need this to be upgraded before we can move forward :D
I think the only really controversial thing here is the change from netcoreapp3.1 to net5.0, because the Ionide/proj-info dependency requires a version of MSBuild that no longer seems to provide a netcoreapp3.1 binary. The tests all seem to be passing after this change as well.