Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation and tests for <seealso> when cref omits arguments #790

Merged
merged 4 commits into from
Jan 16, 2023

Conversation

davedawkins
Copy link
Contributor

As promised in #789. I remembered to format all the source files this time. Let's see if I forgot any...

Copy link
Collaborator

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you!
Could you please remove that findIList function?

src/FSharp.Formatting.ApiDocs/GenerateModel.fs Outdated Show resolved Hide resolved
src/FSharp.Formatting.ApiDocs/GenerateModel.fs Outdated Show resolved Hide resolved
Refactor Option.defaultValue to explicit match
Copy link
Collaborator

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again very much!
It is really cool to see you fix the gaps you encounter!
You could have complained or picked another tool altogether, yet you chose to be a part of the solution 🤘🚀

@nojaf nojaf merged commit a9ecebc into fsprojects:main Jan 16, 2023
@davedawkins
Copy link
Contributor Author

@nojaf -- wait!! There are other tools ?:-D

Thank you for your kind words. The appreciation is very welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants