Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More details/member docs tweaks #919

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Conversation

brianrourkeboll
Copy link
Member

@brianrourkeboll brianrourkeboll commented Jun 3, 2024

Followup to #917.

image

Footnotes

  1. I guess we could just always show the XML/markdown copy links as well, which might look nicer, even though they'd be useless?

@brianrourkeboll brianrourkeboll marked this pull request as ready for review June 3, 2024 18:08
Copy link
Collaborator

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good now:

image

@nhirschey, @kMutagene I would like to ship this one as another revision.
Though it technically is a breaking change. The generated HTML for the API documentation is different, so folks which have custom styling for these pages might end up having problems after updating.
Although I'm not really aware of anyone that would face this problem. So, I'm not overly inclined to bump the major version for this. Any objections?

@nhirschey
Copy link
Collaborator

Shipping as revision sounds good to me. The new styling is still pretty new.

@nojaf
Copy link
Collaborator

nojaf commented Jun 5, 2024

Alright, going to merge this one in and ship a new release with the next version.

@nojaf nojaf merged commit 6bd2905 into fsprojects:main Jun 5, 2024
3 checks passed
@brianrourkeboll brianrourkeboll deleted the deets-2 branch June 5, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants