Merge pull request #251 from dsyme/fix8

fix warnings and add TreatWarningsAsErrors

.travis.yml

@@ -18,11 +18,13 @@ matrix:
     - mono: latest
       env: USE_MSBUILD=1
       os: linux
-    - mono: weekly
-      env: USE_MSBUILD=1
-      os: linux
 
 sudo: true  # use the new container-based Travis infrastructure
 
 script:
   - ./build.sh Pack
+
+allow_failures:
+    - mono: weekly
+      env: USE_MSBUILD=1
+      os: linux

README.md

@@ -81,6 +81,37 @@ See examples the [`examples`](examples) directory.
 * ComboProvider: the TPDTC and TPRTC are combined together in one assembly which is a single `netstandard2.0` component 
 * BasicProvider: the TPDTC and TPRTC are each available as both `netstandard2.0` and `.NET 4.x` components
 
+
+## Type Provider Naming Conventions
+
+A type provider is simultaneously a tool and a library.  The existing guidance is as follows, from https://fsharp.github.io/2014/09/19/fsharp-libraries.html.
+
+> Likewise, a type provider for a data source or schema format XYZ should normally be placed in “FSharp.Data”, e.g. “FSharp.Data.XYZ”.
+
+Good type provider naming examples:
+
+* `FSharp.Text.RegexProvider`
+
+* `FSharp.Azure.StorageTypeProvider`
+
+Existing type providers that don't quite follow the guidelines but which are ok:
+
+* `FSharp.Data`
+
+Here are some examples of existing type providers that aren't too bad (they are clear) but could be renamed to follow the guidelines:
+
+* `ExcelProvider` (better would be `FSharp.Interop.ExcelProvider`)
+
+* `RProvider` (better would be `FSharp.Interop.RProvider`)
+
+* `ApiaryProvider` (better would be `FSharp.Data.ApiaryProvider`)
+
+* `SQLProvider`  (better would be `FSharp.Data.SQLProvider`)
+
+* `DynamicsNAVProvider`  (better would be `FSharp.Interop.DynamicsNAVProvider`)
+
+* `DynamicsCRMProvider`  (better would be `FSharp.Interop.DynamicsCRMProvider`)
+
 ## Technical Notes
 
 ### Using Type Providers with ``dotnet build``

build.fsx

@@ -33,7 +33,7 @@ let release =
     |> ReleaseNotesHelper.parseReleaseNotes
 
 let useMsBuildToolchain = environVar "USE_MSBUILD" <> null
-let dotnetSdkVersion = "2.1.201"
+let dotnetSdkVersion = "2.1.401"
 let sdkPath = lazy DotNetCli.InstallDotNetSDK dotnetSdkVersion
 let getSdkPath() = sdkPath.Value
 

fsc.props

@@ -10,6 +10,18 @@
     <FscToolPath>C:\Program Files (x86)\Microsoft SDKs\F#\4.1\Framework\v4.0</FscToolPath>
     <FscToolExe>fsc.exe</FscToolExe>
   </PropertyGroup>
+  <PropertyGroup Condition="'$(IsWindows)' == 'true' AND Exists('C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\CommonExtensions\Microsoft\FSharp\fsc.exe')">
+    <FscToolPath>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\CommonExtensions\Microsoft\FSharp</FscToolPath>
+    <FscToolExe>fsc.exe</FscToolExe>
+  </PropertyGroup>
+  <PropertyGroup Condition="'$(IsWindows)' == 'true' AND Exists('C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\IDE\CommonExtensions\Microsoft\FSharp\fsc.exe')">
+    <FscToolPath>C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\IDE\CommonExtensions\Microsoft\FSharp</FscToolPath>
+    <FscToolExe>fsc.exe</FscToolExe>
+  </PropertyGroup>
+  <PropertyGroup Condition="'$(IsWindows)' == 'true' AND Exists('C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\CommonExtensions\Microsoft\FSharp\fsc.exe')">
+    <FscToolPath>C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\CommonExtensions\Microsoft\FSharp</FscToolPath>
+    <FscToolExe>fsc.exe</FscToolExe>
+  </PropertyGroup>
   <PropertyGroup Condition="'$(IsWindows)' == 'true' AND Exists('C:\Program Files (x86)\Microsoft SDKs\F#\10.1\Framework\v4.0\fsc.exe')">
     <FscToolPath>C:\Program Files (x86)\Microsoft SDKs\F#\10.1\Framework\v4.0</FscToolPath>
     <FscToolExe>fsc.exe</FscToolExe>

paket.dependencies

@@ -16,3 +16,10 @@ group fs40
     source https://api.nuget.org/v3/index.json
     nuget FSharp.Core ~> 4.0.0
 
+group fs41
+    source https://api.nuget.org/v3/index.json
+    nuget FSharp.Core ~> 4.1.18
+
+group fs45
+    source https://api.nuget.org/v3/index.json
+    nuget FSharp.Core ~> 4.5.2

src/FSharp.TypeProviders.SDK.fsproj

@@ -5,6 +5,7 @@
     <OutputType>Library</OutputType>
     <DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
     <AppendRuntimeIdentifierToOutputPath>false</AppendRuntimeIdentifierToOutputPath>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
   <ItemGroup>
     <Compile Include="ProvidedTypes.fsi" />

src/ProvidedTypes.fs

@@ -154,6 +154,8 @@ namespace ProviderImplementation.ProvidedTypes
         type Attributes<'T when 'T :> Attribute>() = 
             static let empty = ([| |] : 'T []) |> box |> unbox<obj[]>
             static member Empty() = empty
+
+        type Attributes = 
             static member CreateEmpty (typ : Type) =
                 let gtype = typedefof<Attributes<_>>.MakeGenericType([| typ |])
                 let gmethod = gtype.GetMethod("Empty", BindingFlags.Static ||| BindingFlags.NonPublic )

src/ProvidedTypesTesting.fs

@@ -709,6 +709,7 @@ module internal Targets =
            | "3.1" -> "fs31"
            | "4.0" -> "fs40"
            | "4.1" -> "fs41"
+           | "4.5" -> "fs45"
            | _ -> failwith ("unimplemented F# version" + fsharp)
         let compatProfiles =
             match profile with