Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

referencing ProvidedTypes in Runtime project? is it needed? #355

Closed
smoothdeveloper opened this issue Dec 21, 2020 · 0 comments · Fixed by #362
Closed

referencing ProvidedTypes in Runtime project? is it needed? #355

smoothdeveloper opened this issue Dec 21, 2020 · 0 comments · Fixed by #362

Comments

@smoothdeveloper
Copy link
Contributor

AFAIU, referencing the ProvidedTypes.fs files in the runtime assembly is not necessary:

https://github.com/fsprojects/FSharp.TypeProviders.SDK/blob/88696001fe4d5e841ef86955a6507bff3c27e4a6/templates/content/basic/src/MyProvider.Runtime/paket.references

For example, I've removed it in fsprojects/FSharp.Data.SqlClient#398 with no unexpected side effects.

Can this get confirmed and fixed, or be explained in which context those files should be compiled in the runtime assembly?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't need to refer to ProvidedTypes.fs at runtime Happypig375/FSharp.TypeProviders.SDK
1 participant
@smoothdeveloper