Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed FSharpLint code issues #397

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Fixed FSharpLint code issues #397

merged 1 commit into from
Nov 13, 2023

Conversation

Thorium
Copy link
Member

@Thorium Thorium commented Nov 8, 2023

Minor code-clean-up things:

  • isNull is faster than = null
  • Error messages should have some meaningful parameters
  • TryGetValue is faster than ContainsKey + lookup

@Thorium Thorium mentioned this pull request Nov 8, 2023
Merged
cartermp
cartermp approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good overall, thanks

@cartermp cartermp merged commit 6149ed5 into fsprojects:master Nov 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thorium @cartermp