Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extern declarations cause "Bad usage of failwith:" warning #561

Closed
webwarrior-ws opened this issue Aug 1, 2022 · 0 comments · Fixed by #562
Closed

extern declarations cause "Bad usage of failwith:" warning #561

webwarrior-ws opened this issue Aug 1, 2022 · 0 comments · Fixed by #562

Comments

@webwarrior-ws
Copy link
Contributor

webwarrior-ws commented Aug 1, 2022 •
edited
Loading

Description

extern declarations cause "Bad usage of failwith:" warning

Repro steps

Run linter against code:

[<DllImport("LogitechLedEnginesWrapper", CallingConvention=CallingConvention.Cdecl)>]
extern bool LogiLedInit()

[<DllImport("LogitechLedEnginesWrapper", CallingConvention=CallingConvention.Cdecl)>]
extern bool LogiLedSetLighting(int redPercenatge, int greenPercenatge, int bluePercenatge)

Note: must be at least 2 extern declarations

Expected behavior

No errors or warnigns.

Actual behavior

The following warning is issued:

Bad usage of failwith: consider using unique error messages as parameters.
Error on line 5 starting at column 0
extern bool LogiLedSetLighting(int redPercenatge, int greenPercenatge, int bluePercenatge)
^
webwarrior-ws added a commit to webwarrior-ws/FSharpLint that referenced this issue Aug 1, 2022
@webwarrior-ws
Added test case for multiple extern declarations
f1695a1 
See issue fsprojects#561
webwarrior-ws added a commit to webwarrior-ws/FSharpLint that referenced this issue Aug 1, 2022
@webwarrior-ws
Bugfix in FailwithBadUsage rule
e347c14 
Ignore certain message auto-generated by F# compiler in place of "extern" declarations.
Fixes fsprojects#561
@webwarrior-ws webwarrior-ws mentioned this issue Aug 1, 2022
Merged
webwarrior-ws added a commit to webwarrior-ws/FSharpLint that referenced this issue Aug 1, 2022
@webwarrior-ws
Added new test case
f4bebbc 
This time test case is for multiple extern declarations, but without DllImport attribute
See issue fsprojects#561
knocte pushed a commit that referenced this issue Dec 7, 2023
@webwarrior-ws
FailwithBadUsage: extern declarations bugfix (#562)
64ca94f 
Fixes #561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix in FailwithBadUsage rule webwarrior-ws/FSharpLint
1 participant
@webwarrior-ws