Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conventions/Naming: rename Accessibility DU to AccessControlLevel #565

Merged
merged 1 commit into from
Oct 16, 2022
Merged

Conventions/Naming: rename Accessibility DU to AccessControlLevel #565

merged 1 commit into from
Oct 16, 2022

Conversation

webwarrior-ws
Copy link
Contributor

Also added comment to AccessControlLevel describing relationships between values of this DU.

@knocte knocte merged commit 14fe636 into fsprojects:master Oct 16, 2022
@knocte
Copy link
Collaborator

knocte commented Oct 16, 2022

@webwarrior-ws looked at the some code after I merged this and realized we should have renamed other stuff, so can you create another PR covering this:

  • Parameter "isPublic" in getValueOrFunctionIdents is not of bool type, but AccessControlLevel type, let's rename it.
  • Nested function isSynAccessPublic doesn't return bool so it has a confusing name too, let's rename it.
  • Function getAccessibility returns AccessControlLevel so let's rename it too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webwarrior-ws @knocte