Rename functions and parameters dealing with AccessControlLevel #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knocte
reviewed
Oct 17, 2022
knocte
reviewed
Oct 17, 2022
| @@ -209,15 +209,15 @@ let getAccessibility (syntaxArray:AbstractSyntaxArray.Node []) i = | |||
| | ExceptionRepresentation(SynExceptionDefnRepr.SynExceptionDefnRepr(_, _, _, _, access, _)) | |||
| | Pattern(SynPat.Named(_, _, _, access, _)) | |||
| | Pattern(SynPat.LongIdent(_, _, _, _, access, _)) -> | |||
| getAccessibility (isSynAccessPublic access) isPrivateWhenReachedBinding node.ParentIndex | |||
| getAccessibility (resolveAccessControlLevel access) isPrivateWhenReachedBinding node.ParentIndex | |||
There was a problem hiding this comment.
@webwarrior-ws does this build actually? or is there another function named getAccessibility that needs to be renamed?
There was a problem hiding this comment.
Yes, it builds. That's inner function and I decided not to rename it so that it's named differently from top-level function
knocte
reviewed
Oct 17, 2022
webwarrior-ws
force-pushed
the
acl-refactoring
branch
from
6512715
to
efbb8d7
Compare
knocte
reviewed
Oct 17, 2022
src/FSharpLint.Core/Rules/Conventions/Naming/InternalValuesNames.fs
Outdated
Show resolved
Hide resolved
Renamed some functions and/or parameters related to AccessControlLevel to make their intent more clear.
webwarrior-ws
force-pushed
the
acl-refactoring
branch
from
efbb8d7
to
034dfe0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed some functions and/or parameters
related to AccessControlLevel to make their
intent more clear.