Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A new rule that finds used underscore prefixed elements #591

Closed
wants to merge 35 commits into from
Closed

A new rule that finds used underscore prefixed elements #591

wants to merge 35 commits into from

Conversation

tehraninasab
Copy link
Contributor

@tehraninasab tehraninasab commented Nov 24, 2022 •
edited
Loading

Fixes #573

@tehraninasab
Configuration: add rule to ConventionsConfig
1e97879
@tehraninasab
Configuration: add rule to Configuration
ff6c9c9
@tehraninasab
Configuration: add to flattenConfig
ce2290e
@tehraninasab
add a reference to new rule's source code file
7534187
@tehraninasab
fsharplint: enable new rule
b54c9fb
@tehraninasab
Text: add error message for the new rule
ef50bef
@tehraninasab
Identifiers: add identifier for new rule
773f553
@tehraninasab
rule-configuration: add new rule
ab5bb0d
@tehraninasab
docs: add new rule's docs
15846dd
@tehraninasab
Add new rule's file
d5fa388
@tehraninasab
FsharpLint.Core.Tests: failing test for new rule
c21c275
@tehraninasab
FSharpLint.Core.Tests: add rule's test to fsproj
a3ae45c
@tehraninasab
FSharpLint.Core.Tests: better parsing code
402fa4a
@tehraninasab
FSharpLint.Core.Tests: fix
ee59076
@tehraninasab
FSharpLint.Core.Test: fix
9d667d6
@tehraninasab
FSharpLint.Core: implement new rule
c2e4ca5
@tehraninasab
FSharpLint.Core.Test: one more test
ab3601c
@tehraninasab
FSharpLint.Core.Tests: add one failing test
88fc879
@tehraninasab
FSharpLint.Core: fix the rule
2f2d488
@tehraninasab
FSharpLint.Core: refactor
1da2485 
Recator in order to avoid using mutable variables
@tehraninasab
FSharpLint.Core: fix match indentation
6f1f50c
@tehraninasab
FSharpLint.Core: remove unnecessary parens
372e7f9
@tehraninasab
FsharpLint.Core: rename function
557804c
@tehraninasab
FSharpLint.Core.Tests: test with type
edd1480
@tehraninasab
FShapLint.Core.Tests: test for private member
75a68ae
@tehraninasab
FSharpLint.Core.Tests: test for private property
3ec8f8c
@tehraninasab
FSharpLint.Core.Tests: rename the type
edbc49f
@webwarrior-ws webwarrior-ws mentioned this pull request Dec 20, 2023
Merged
@knocte
Copy link
Collaborator

knocte commented Dec 20, 2023

Superseded by #643

@knocte knocte closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knocte knocte knocte left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule to find used _elements
2 participants
@tehraninasab @knocte