Rule that suggest using auto-property #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webwarrior-ws
force-pushed
the
suggest-use-member-val
branch
from
ec25c30
to
fb72d73
Compare
knocte
reviewed
Dec 6, 2023
src/FSharpLint.Core/Rules/Conventions/SuggestUseAutoProperty.fs
Outdated
Show resolved
Hide resolved
knocte
reviewed
Dec 6, 2023
knocte
reviewed
Dec 6, 2023
|
@webwarrior-ws can you rebase this please? |
|
@webwarrior-ws also update the Introduced in... text. |
webwarrior-ws
force-pushed
the
suggest-use-member-val
branch
from
17cb08b
to
4c93a90
Compare
|
@knocte rebased |
knocte
reviewed
Dec 14, 2023
|
|
||
| let rule = | ||
| { Name = "SuggestUseAutoProperty" | ||
| Identifier = Identifiers.FavourConsistentThis |
There was a problem hiding this comment.
@webwarrior-ws this is a typo here, please fix
Add a rule that suggest usage of auto-property for property with getter that only returns some (immutable) value. Add tests for it. Co-authored-by: Mehrshad <code.rezaei@gmail.com>
Implement rule introduced in previous commit and make it pass the tests. Co-authored-by: Mehrshad <code.rezaei@gmail.com>
Added 2 more tests: for porperty returning literal value and for property returing mutable variable.
Check if returned value is a mutable variable, and only return warning if it's not. Makes test added in previous commit green.
Update configuration and docs to include SuggestUseAutoProperty rule.
Added tests for cases when property returns array or list of immutable values.
Make rule pass tests introduced in previous commit by checking if poperty returns list or array of immutable values.
Added test that checks that rule is not applied to static properties.
Make rule pass test introduced in previous commit by checking if poperty is static or instance property.
Added a test for suggested fix.
Implement quick fix suggestion for the rule.
Added unit tests where `__` and `this` is used (instead of self).
Addressed comments to the PR.
webwarrior-ws
force-pushed
the
suggest-use-member-val
branch
from
1702015
to
fba8714
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add rule that suggests usage of auto-property (
member val Foo) whenmember self.Foois unnecessary.Fixes #596.