FavourStaticEmptyFields: fix issue 630 #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added checks for error message containing substitution that is appropriate for given data type (array or list) in FavourStaticEmptyFields tests. E.g. `Array.empty` should be suggested for replacing `[||]`.
Fixed bug in FavourStaticEmptyFields rule that caused wrong suggestion for arrays (List.Empty instead of Array.empty). Fixes fsprojects#630
Simplified FavourStaticEmptyFields rule by removing unnecessary code. Fixes fsprojects#630
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added checks for error message containing substitution that is appropriate for given data type (array or list) in
FavourStaticEmptyFieldstests. E.g.Array.emptyshould be suggested for replacing[||].Fixed bug in FavourStaticEmptyFields rule that caused wrong suggestion for arrays.
Simplified FavourStaticEmptyFields rule by removing unnecessary code.
Fixes #630