Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build.fsx,RELEASE.md: improve preRelease version numbers #642

Merged
merged 2 commits into from
Dec 20, 2023
Merged

build.fsx,RELEASE.md: improve preRelease version numbers #642

merged 2 commits into from
Dec 20, 2023

Commits on Dec 20, 2023

  1. build.fsx,RELEASE.md: improve preRelease version numbers 

    After we added[1] support for uploading prerelease nuget packages,
the versions chosen for these would increment the "Minor" part of
the last version released. Example: if last released version was
0.21.7, then the prerelease uploaded would start as something like
'0.22.0-date...'.

But this was not a good strategy because if the next version
released after 0.21.7 is 0.21.8, then the 0.22.x packages would
still be listed earlier than the 0.21.8 package in nuget, falsely
implying that they are "ahead" of 0.21.8, when actually they were
somewhere between 0.21.7 and 0.21.8.

Therefore we now make the increment happen at the Revision level
instead of at the Minor level. So the prereleases after releasing
a "0.21.8" for example, will start as '0.21.9-date...'.

And to be more in line with this change, we're gonna start the
convention of adding +2 to the Revision every time we tag a
release. This way, even numbers will give a "stable" aspect (as
they are not a prerelease anyway): 0.21.8, 0.21.10, 0.21.12...
And odd numbers will be prereleases: 0.21.9-date..., 0.21.11-date...

[1] 9618a8a
    @knocte
    knocte committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    901553c View commit details
    Browse the repository at this point in the history

  2. {README,RELEASE}.md: merge two releasing guidelines into one 

    Matt added this guide recently[1] without realising that we had
already a small section about it in the README file. I converged
now both guides into one.

[1] 25c723c
    @knocte
    knocte committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    29b80b6 View commit details
    Browse the repository at this point in the history