Fix AvoidSinglePipeOperator false negative in all inner expressions #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@webwarrior-ws please review |
src/FSharpLint.Core/Rules/Conventions/AvoidSinglePipeOperator.fs
Outdated
Show resolved
Hide resolved
src/FSharpLint.Core/Rules/Conventions/AvoidSinglePipeOperator.fs
Outdated
Show resolved
Hide resolved
src/FSharpLint.Core/Rules/Conventions/AvoidSinglePipeOperator.fs
Outdated
Show resolved
Hide resolved
src/FSharpLint.Core/Rules/Conventions/AvoidSinglePipeOperator.fs
Outdated
Show resolved
Hide resolved
src/FSharpLint.Core/Rules/Conventions/AvoidSinglePipeOperator.fs
Outdated
Show resolved
Hide resolved
src/FSharpLint.Core/Rules/Conventions/AvoidSinglePipeOperator.fs
Outdated
Show resolved
Hide resolved
Mersho
force-pushed
the
FalseNegativeAvoidSinglePipeOperator
branch
3 times, most recently
from
6f09eda
to
b83de98
Compare
|
@webwarrior-ws all good now? |
Mersho
force-pushed
the
FalseNegativeAvoidSinglePipeOperator
branch
4 times, most recently
from
f995950
to
a392d8c
Compare
src/FSharpLint.Core/Rules/Conventions/AvoidSinglePipeOperator.fs
Outdated
Show resolved
Hide resolved
src/FSharpLint.Core/Rules/Conventions/AvoidSinglePipeOperator.fs
Outdated
Show resolved
Hide resolved
Switched to using `Seq.isEmpty` instead of comparing array length.
Mersho
force-pushed
the
FalseNegativeAvoidSinglePipeOperator
branch
from
a392d8c
to
ee54702
Compare
This test was incorporated following the suggestion of @webwarrior-ws to include a test case that utilizes three pipe operators [1]. [1] fsprojects#697 (review)
Mersho
force-pushed
the
FalseNegativeAvoidSinglePipeOperator
branch
from
ad62f26
to
8a93684
Compare
|
@Mersho please re-run CI build of the commit titled "AvoidSinglePipeOperator: fix for all inner exprs" |
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.