Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to do a comparison of forced UseVirtualTag #7

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Attempt to do a comparison of forced UseVirtualTag #7

wants to merge 6 commits into from

Conversation

manofstick
Copy link
Member

Just creating PR to get AppVeyor to do some work...

This is just a shotgun approach to UseVirtualTag, and still tweaks are required, but should be a reasonable baseline...

forki
forki reviewed Sep 8, 2016
View reviewed changes
build.fsx
let compilerForkToTest = @"https://github.com/forki/visualfsharp"
let compilerHashes = ["71c8798e19d6e15d3e6a98c80da658aa5ed2c630"; "ee0baed"]
let compilerForkToTest = @"https://github.com/manofstick/visualfsharp"
let compilerHashes = ["5c931e3149ebdd5d1e5f9721a3c6dbfb63e9d1c6"; "9d5e36a7aa66f029640aa05f96bd7b54907aef81"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need some way to alias. I assume branch names will just work

@forki
Copy link
Member

forki commented Sep 8, 2016 

Compiler: 5c931e3149ebdd5d1e5f9721a3c6dbfb63e9d1c6
   Project: Paket 11872.0ms
   Project: FSharpx.Collections 2524.0ms
   Project: FSharp.Data 4001.0ms
   Project: SQLProvider 7960.0ms
   Average Run: 26358.0ms
Compiler: 9d5e36a7aa66f029640aa05f96bd7b54907aef81
   Project: Paket 11486.0ms
   Project: FSharpx.Collections 2404.0ms
   Project: FSharp.Data 3874.0ms
   Project: SQLProvider 7598.0ms
   Average Run: 25363.0ms

@forki forki mentioned this pull request Sep 8, 2016
Closed
@forki
Copy link
Member

forki commented Sep 8, 2016

this looks awesome. Only question is how trustworthy my perf framework is...

@manofstick
Copy link
Member Author

Well a bit more what I was expecting:

Compiler: 32c530ebe42f34a863a9e55b682f90685e658125
Project: Paket 11217.0ms
Project: FSharpx.Collections 2424.0ms
Project: FSharp.Data 3801.0ms
Project: SQLProvider 7483.0ms
Average Run: 24926.0ms
Compiler: 9d5e36a7aa66f029640aa05f96bd7b54907aef81
Project: Paket 11266.0ms
Project: FSharpx.Collections 2417.0ms
Project: FSharp.Data 3831.0ms
Project: SQLProvider 7383.0ms
Average Run: 24898.0ms

But times obviously jump around a bit; because the unmodified changeset went from:

Compiler: 9d5e36a7aa66f029640aa05f96bd7b54907aef81
Average Run: 25363.0ms (run from other day)
to
Average Run: 24898.0ms (today's run)

Which is an almost 2% change; so probably hard to detect any minor changes, but atleast should detect any major problems...

@manofstick
Check when Map and Set use UseVirtualTag
32cd73c
@manofstick
Checking alternative List.filter
9a2cf94 
Shouldn't really change the performance at all, so just check that that
is true, within the scope of the AppVeyor environment...
@manofstick
Flipping the build ordering
7eaaa6b 
See if the results are consistent...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manofstick @forki