Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added slighly more meaningful messages to a few matchers #115

Merged
merged 2 commits into from
Dec 15, 2017

Conversation

bhjoellund
Copy link
Contributor

Hi!

I was experiencing a few weird error messages, like

Error Message:
 FsUnit.Xunit+MatchException : Exception of type 'FsUnit.Xunit+MatchException' was thrown.
Expected: 1
Actual:   was 1

which does not make a lot of sense, so I added some slightly more meaningful messages to those matchers.

@sergey-tihon
Copy link
Member

Thank you @mofibrian !
Could you please use %A in formatters?

sprintf "Greater than %A" x

instead of

sprintf "Greater than %s" (string x)

@bhjoellund
Copy link
Contributor Author

Hey @sergey-tihon

Absolutely, I'll update the PR.

@sergey-tihon sergey-tihon merged commit 4c0812f into fsprojects:master Dec 15, 2017
@sergey-tihon
Copy link
Member

Thank you!

@bhjoellund
Copy link
Contributor Author

You're welcome :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants