[Cosmetic] Refactorings & Fantomas integration #157
Conversation
|
With such big reformatting, I believe it make sense to adopt https://github.com/fsprojects/fantomas @CaptnCodr do you want to try this? |
|
I didn't ever use Fantomas but I'll try this. |
|
Thank you! I also never integrate it with repo before. |
|
It does make sense to push the fantomas integration into this PR, isn't it? |
|
Yes, I also think so
…Sent from my iPhone
On Jun 30, 2020, at 08:40, Constantin Tews ***@***.***> wrote:
It does make sense to push the fantomas integration into this PR, isn't it?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Hey @sergey-tihon, I added Fantomas now. :) |
|
I am not really have with formatting like I've upgraded Fantomas to latest prerelease version and slightly upgrade config. |
|
Oh yes. That's definitely better. |
|
We could replace all |
# Conflicts: # paket.lock # src/FsUnit.NUnit/FsUnit.fs # src/FsUnit.NUnit/FsUnitTyped.fs # src/FsUnit.NUnit/GenericAssert.fs # tests/FsUnit.NUnit.Test/equalTests.fs # tests/FsUnit.Xunit.Test/equalTests.fs
sergey-tihon
changed the title
| let f = | ||
| FastGenericEqualityComparer<'T>.Equals(x, y) | ||
|
|
||
| printfn "Ref returns %b" f |
There was a problem hiding this comment.
@marklam I missed this line in your formatting. Why do you printf to console here?
This PR includes:
list<_>,array<_>,seq<_>were removed twice, it runs underIEnumerabletooCollectionContainsConstraintwas marked as obsolete: it's nowHas.Some.EqualToas recommendedCustomMatchers.fs: 4x tabs (4 spaces) in function bodynew Type,open NHamcrest.Core,yields inseq { yield ... }System.Collections.IEnumerablebutSystem.Collectionswere openeda: Type(docs.microsoft)Altogether, the code is more readable.