Skip to content

Change LOCKEDVERSION operator in nuget package template #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2023
Merged

Change LOCKEDVERSION operator in nuget package template #254

merged 1 commit into from
Nov 10, 2023

Conversation

CaptnCodr
Copy link
Member

  • Set xunit to v2.5.3
  • Update NUnit dependency
  • >= LOCKEDVERSION for broader compatibility

Closes #253

abelbraaksma
abelbraaksma approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@abelbraaksma abelbraaksma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit that may or may not be important

@CaptnCodr CaptnCodr merged commit 0cae591 into fsprojects:master Nov 10, 2023
@CaptnCodr CaptnCodr deleted the bugfix/dependencies-upper-bound branch November 10, 2023 20:21
@abelbraaksma abelbraaksma mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abelbraaksma abelbraaksma abelbraaksma approved these changes

@sergey-tihon sergey-tihon Awaiting requested review from sergey-tihon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not use an upper bound on dependencies, unless you have to
2 participants
@CaptnCodr @abelbraaksma