Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix FAKE download #16

Merged
merged 5 commits into from
Jan 3, 2018
Merged

fix FAKE download #16

merged 5 commits into from
Jan 3, 2018

Conversation

forki
Copy link
Member

@forki forki commented Jan 3, 2018

No description provided.

@forki forki mentioned this pull request Jan 3, 2018
@tomasaschan
Copy link

OK, now the Linux builds are failing because they're not looking in the correct directory (although I'm pretty sure it should be there). I just managed to reproduce this locally under WSL, so I'll take a look.

@tomasaschan
Copy link

Opened #17 against this branch; if that works, we can merge it in here to make sure this works against master too :)

@forki
Copy link
Member Author

forki commented Jan 3, 2018

still not working completely

@tomasaschan
Copy link

tomasaschan commented Jan 3, 2018

Hm. It seems the Mono machines don't have dotnet installed, and our build.fsx apparently fails when determining if it should install it... I'll take a look at it when I get home. In the meantime, feel free to turn off Travis builds if the red ligths discourage you (Appveyor works, so it's strictly a prerequisites issue on Linux...).

@fbehrens
Copy link
Contributor

fbehrens commented Jan 3, 2018

Build is now succeeding on osx.
But afterward I have dirty git worktree with a modified src/.paket/Paket.Restore.targets
The LF were replace by CRLF.
Not sure how to fix this.

@tomasaschan
Copy link

Not sure what's appropriate for this file specifically, but line endings are always something you have to handle when you work in a team with different platforms on their workstation :)

Here's a relevant summary of what the problem is and potential ways to deal with it: https://help.github.com/articles/dealing-with-line-endings/#platform-all

Note the platform switch at the top; the Mac instructions might have some hints to get this right on your machine (or maybe I have to do something on mine...)

@tomasaschan
Copy link

We could, most likely, force whatever setting we decide on onto all contributors in the .gitattributes file much like I did with .sh files. It would be better though to make git checkout the files correctly on any platform.

@tomasaschan
Copy link

@fbehrens Thanks for testing! If it's working on OSX, I'm pretty confident that the build issues on travis can be fixed in .travis.yml and only there.

For the line endings issue, see my comments above.

@forki
Copy link
Member Author

forki commented Jan 3, 2018

https://github.com/SAFE-Stack/SAFE-BookStore/blob/master/build.fsx#L112 allows to download dotnet locally. But it's a FAKE 4 feature that's not fully ported to FAKE 5. Pinging @matthid

@tomasaschan
Copy link

tomasaschan commented Jan 3, 2018

@forki We're doing that too, but I think this line is the one causing trouble. In the SAFE example, the corresponding line uses a different API that I couldn't find (with IntelliSense), which is why I assumed it was moved. Apparently, I instead use dotnet --version which obviously fails if dotnet is not installed.

@fbehrens
Copy link
Contributor

fbehrens commented Jan 3, 2018

@tlycken will you pull this into master and we'll open a new issue for installing dotnetCore ?

@tomasaschan tomasaschan merged commit 46584c4 into master Jan 3, 2018
@tomasaschan tomasaschan deleted the nostorage branch January 3, 2018 12:14
@tomasaschan tomasaschan mentioned this pull request Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants