-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix FAKE download #16
Conversation
OK, now the Linux builds are failing because they're not looking in the correct directory (although I'm pretty sure it should be there). I just managed to reproduce this locally under WSL, so I'll take a look. |
Opened #17 against this branch; if that works, we can merge it in here to make sure this works against master too :) |
Fix build sh
still not working completely |
Hm. It seems the Mono machines don't have |
Build is now succeeding on |
Not sure what's appropriate for this file specifically, but line endings are always something you have to handle when you work in a team with different platforms on their workstation :) Here's a relevant summary of what the problem is and potential ways to deal with it: https://help.github.com/articles/dealing-with-line-endings/#platform-all Note the platform switch at the top; the Mac instructions might have some hints to get this right on your machine (or maybe I have to do something on mine...) |
We could, most likely, force whatever setting we decide on onto all contributors in the |
@fbehrens Thanks for testing! If it's working on OSX, I'm pretty confident that the build issues on travis can be fixed in For the line endings issue, see my comments above. |
https://github.com/SAFE-Stack/SAFE-BookStore/blob/master/build.fsx#L112 allows to download dotnet locally. But it's a FAKE 4 feature that's not fully ported to FAKE 5. Pinging @matthid |
@forki We're doing that too, but I think this line is the one causing trouble. In the SAFE example, the corresponding line uses a different API that I couldn't find (with IntelliSense), which is why I assumed it was moved. Apparently, I instead use |
@tlycken will you pull this into |
No description provided.