Forge integration #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm closing this PR because I don't think this approach is ideal any longer. After playing around with this a good bit more my feeling is it will be simpler and faster to take the original approach of parsing the project file xml and making the ordering adjustment ourselves. If someone feels differently please let me know. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few basic utility functions that get us started with Forge integration. I'd appreciate a bit of advice about how we expect to package and reference
Forge.exein our build as I'm a bit unsure of best practices @tlycken @forki?I've also switched us over to
Expecto, which requires a simple run of the test project executable. This has brokendotnet testthough, any thoughts on how to fix @tlycken?Also just something I was thinking about while looking through the
Forgedocs. As far as I can tell it provides no ability to bulk reorder files in a project. Justmove upandmove downcommands orremoveandadd, which require separate individual calls. Is there a concern that this will be slow for larger projects?