Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align with spec requirements, meaning no leading zeroes on semVers #2319

Closed
wants to merge 7 commits into from

Conversation

baronfel
Copy link
Contributor

@baronfel baronfel commented May 7, 2017

per the spec:

A normal version number MUST take the form X.Y.Z where X, Y, and Z are non-negative integers, and MUST NOT contain leading zeroes. X is the major version, Y is the minor version, and Z is the patch version. Each element MUST increase numerically. For instance: 1.9.0 -> 1.10.0 -> 1.11.0.

Emphasis mine

@baronfel
Copy link
Contributor Author

baronfel commented May 7, 2017

Actually found this when I was integrating this module into FAKE, thanks to the tests over there.

Copy link
Member

@forki forki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is red. Can you please check

@cdrnet
Copy link
Member

cdrnet commented May 8, 2017

Note that 0 starts with 0 as well, and 0.1.0 is a perfectly valid version number.

@forki
Copy link
Member

forki commented May 8, 2017 via email

@forki
Copy link
Member

forki commented May 23, 2017

ping

@baronfel
Copy link
Contributor Author

baronfel commented May 23, 2017 via email

@baronfel
Copy link
Contributor Author

ok this is looking fixed up now. I'm super curious what it would take to move us over to SemVer.net instead of a home grown parse, and it looks like we mostly have a

  1. semi-convention around the 'name' of the prerelease segment being the first alpha segment,
  2. various tostring functions that normalize for nuget (which may not be necessary anymore if the 3.4+ documentation is correct in that they strip leading zeroes, and trailing 4th segment zeroes)

@forki
Copy link
Member

forki commented Jun 11, 2017

@baronfel the issue is always to support old released nupkg that don't conform to semver

@forki
Copy link
Member

forki commented Feb 21, 2018

we recently made paket more conform to semver. So hope it's better now.

@forki forki closed this Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants