-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
align with spec requirements, meaning no leading zeroes on semVers #2319
Conversation
Actually found this when I was integrating this module into FAKE, thanks to the tests over there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build is red. Can you please check
Note that |
We also need to support 0 itself since it is used in “=> 0" all over the
place
Am 08.05.2017 8:28 vorm. schrieb "Christoph Ruegg" <notifications@github.com
…:
Note that 0 starts with 0 as well, and 0.1.0 is a perfectly valid version
number.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2319 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNJsTeS0xXFpwoAeZpnGPW6MQLUN1ks5r3rYXgaJpZM4NTRDA>
.
|
ping |
Sorry this has taken so long, I'm in vacation without a computer but can
take a look on Saturday.
…On Tue, May 23, 2017, 4:39 AM Steffen Forkmann ***@***.***> wrote:
ping
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2319 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAjCG56dDaZb78WTfbFGcV6yK8kQP_u_ks5r8psugaJpZM4NTRDA>
.
|
… per nuget docs in 3.4+ they no longer require leading zeroes
ok this is looking fixed up now. I'm super curious what it would take to move us over to SemVer.net instead of a home grown parse, and it looks like we mostly have a
|
@baronfel the issue is always to support old released nupkg that don't conform to semver |
we recently made paket more conform to semver. So hope it's better now. |
per the spec:
Emphasis mine