Some improvements #3090
Some improvements #3090
Conversation
| if checkCredentials (url, Some auth) then | ||
| Some auth | ||
| else | ||
| failwithf "Credentials from authentication store for %s are invalid" source |
There was a problem hiding this comment.
Note that this still fails, but a bit later and with one request less
| let inline getPackageIdAttribute (pf:ProjectFile) (node:XmlNode) = | ||
| node |> getAttribute "Include" | ||
| |> Option.orElseWith (fun _ -> node |> getAttribute "Update") | ||
| |> Option.defaultWith (fun _ -> failwithf "project file '%s' contains a reference without 'Include' or 'Update' attribute" pf.FileName) |
There was a problem hiding this comment.
that's a weird technique. throwing in defaultWith!? Seriously?
There was a problem hiding this comment.
What else do you suggest? The only thing it does: Give a better error message in case all other cases fail and defaultWith has the signature I need for this here ;)
There was a problem hiding this comment.
Honestly, I "default" "with" an error message. It doesn't even sound too bad. Is the code better with a match?
src/Paket/Program.fs
Outdated
| for problem in parseProblems |> Seq.map (fun x -> x.AsMessage) do | ||
| Logging.traceWarnfn "Problem: %s" problem | ||
|
|
||
| printfn "Restriction: %s" restrictionRaw |
There was a problem hiding this comment.
please don't use printfn directly. tracefn all the things
There was a problem hiding this comment.
Ok, but but just to make it clear: This is in fact program output no logging
| @@ -776,6 +794,7 @@ let handleCommand silent command = | |||
| | GenerateLoadScripts r -> processCommand silent generateLoadScripts r | |||
| | GenerateNuspec r -> processCommand silent generateNuspec r | |||
| | Why r -> processCommand silent why r | |||
| | Restriction r -> processCommand silent restriction r | |||
There was a problem hiding this comment.
@forki I can remove that from the PR if you don't like it, the rest are bug-fixes
There was a problem hiding this comment.
That's the question, I saw it more like a debug helper for us, but we can make it a feature (honestly I doubt if the regular user can do something with the output)
docs/content/commands/restriction.md
Outdated
| @@ -0,0 +1,36 @@ | |||
| # paket why | |||
|
it's red. |
| @@ -89,7 +89,7 @@ | |||
| </When> | |||
| </Choose> | |||
| <Choose> | |||
| <When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And ($(TargetFrameworkVersion) == 'v4.5.1' Or $(TargetFrameworkVersion) == 'v4.5.2' Or $(TargetFrameworkVersion) == 'v4.5.3')"> | |||
| <When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And ($(TargetFrameworkVersion) == 'v4.5' Or $(TargetFrameworkVersion) == 'v4.5.1' Or $(TargetFrameworkVersion) == 'v4.5.2' Or $(TargetFrameworkVersion) == 'v4.5.3')"> | |||
There was a problem hiding this comment.
I'm not sure what this PR has to do with this change. but it looks correct?
|
So I got it green finally? |
|
no it did not. yet |
No description provided.