Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit tmp.fsx in AST tab dump #498

Closed
auduchinok opened this issue Feb 9, 2023 · 2 comments
Closed

Omit tmp.fsx in AST tab dump #498

auduchinok opened this issue Feb 9, 2023 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@auduchinok
Copy link

If we analyze ranges in the dump in #494, then it also becomes easy enough to remove tmp.fsx file names, so the dump is easier to look at and to reason about.
@nojaf nojaf added help wanted Extra attention is needed good first issue Good for newcomers labels Feb 9, 2023
@nojaf
Copy link
Collaborator

nojaf commented Feb 9, 2023

I don't think #494 is all that related to this suggestion.
The removal of tmp.fsx seems more like a string replacement on the server.
While in #494 you need to respond to the cursor location in the editor.
I'm ok with this suggestion and will mark this up for grabs.

@auduchinok auduchinok mentioned this issue Feb 13, 2023
Merged
@nojaf
Copy link
Collaborator

nojaf commented Mar 17, 2023

This is now done after our latest sync.

@nojaf nojaf closed this as completed Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nojaf @auduchinok