SyntaxTreeTests: use short ranges #14739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would also fix fsprojects/fantomas-tools#498. |
|
@vzarytovskii Do you know if the determinism failure could be connected to this change somehow? |
No, it's just a nuget-related issue, should just rerun /azp run |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
It's ready. |
T-Gro
approved these changes
Feb 14, 2023
0101
reviewed
Feb 14, 2023
auduchinok
force-pushed
the
ast-test-shortRanges
branch
from
b2f5b75 to
c60ed8d
Compare
0101
approved these changes
Feb 14, 2023
KevinRansom
added a commit
to KevinRansom/fsharp
that referenced
this pull request
Feb 20, 2023
This reverts commit a181965.
kant2002
pushed a commit
to kant2002/fsharp
that referenced
this pull request
Apr 1, 2023
* SyntaxTreeTests: use short ranges * Remove ToShortString * Remove ToShortString
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After looking at new parser tests in #13089, I thought the file names in the AST dump only add noise and don't help with anything. Are there any cases where it's really helpful to always have them in
Range.ToString()?This PR removes file names from
Range.ToString()(while it's still available in itsDebuggerDisplay) as an experiment. The syntax tree dumps are much easier to look at now.