-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't check the unfinished expression before dot as the whole expression #14718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf2cede
to
b9c3e2c
Compare
Please merge #14739 first, and I'll update the tests here afterwards. |
@auduchinok there you go :) |
1f0ed47
to
203238a
Compare
@psfinaki Thanks! I've updated parser tests for unfinished expressions ( It's ready now. |
auduchinok
commented
Feb 15, 2023
abonie
approved these changes
Feb 15, 2023
T-Gro
approved these changes
Feb 16, 2023
KevinRansom
added a commit
to KevinRansom/fsharp
that referenced
this pull request
Feb 20, 2023
… expression (dotnet#14718)" This reverts commit 91af626.
KevinRansom
added a commit
to KevinRansom/fsharp
that referenced
this pull request
Feb 20, 2023
… expression (dotnet#14718)" This reverts commit 91af626.
kant2002
pushed a commit
to kant2002/fsharp
that referenced
this pull request
Apr 1, 2023
…ion (dotnet#14718) * Don't check the unfinished expression before dot as the whole expression * More recovery * tmp * Fix record field completion * Fantomas * Update surface area * Fix parsing * Space * Fantomas * Fix tests, add tests for record fields * Another record field test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test PR to check what breaks with this change.
Consider an unfinished expression with a dot at the end:
x.
. In many cases the dot would be ignored and onlyx
expression would be checked. It has bad consequences where the type ofx
is unified with the type that is expected in the context, despite it's an inner expression in another unfinished one:That unexpected
unit
type breaks completion for cases wherex
should infer to have some other type, likestring
here:With this change both cases work as expected (i.e.
x
doesn't have any constraints in the first case and code completion suggestsstring
members in the second one).Another case is applying an argument: