Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use dotnet 8 preview sdk and lang preview #2924

Merged
merged 6 commits into from
Aug 31, 2023
Merged

use dotnet 8 preview sdk and lang preview #2924

merged 6 commits into from
Aug 31, 2023

Conversation

dawedawe
Copy link
Member

To increase our level of dogfooding

  • use dotnet 8 preview sdk
  • use lang preview

@dawedawe
- use dotnet 8 preview sdk
768bd23 
- use lang preview
nojaf
nojaf reviewed Jul 12, 2023
View reviewed changes
Directory.Build.props Outdated
@@ -34,6 +34,7 @@ Some common use cases include:
<!-- https://www.gresearch.co.uk/blog/article/improve-nuget-restores-with-static-graph-evaluation/ -->
<RestoreUseStaticGraphEvaluation>true</RestoreUseStaticGraphEvaluation>
<ServerGarbageCollection>true</ServerGarbageCollection>
<LangVersion>PREVIEW</LangVersion>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it PREVIEW in all caps? Or does that not matter at all?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't matter. Normally, tooling inserts lowercase.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, changed it to lowercase to be more consistent.

@nojaf
Copy link
Contributor

nojaf commented Jul 12, 2023

The documentation fails, I guess fsdocs would need FCS 43.8.100-preview.23327.15 perhaps.
I'll take a look at what needs to be done. Maybe it is a bump in proj-info to deal with dotnet 8 sdk.

@dawedawe
Copy link
Member Author

The documentation fails, I guess fsdocs would need FCS 43.8.100-preview.23327.15 perhaps. I'll take a look at what needs to be done. Maybe it is a bump in proj-info to deal with dotnet 8 sdk.

Thanks!

@nojaf
Copy link
Contributor

nojaf commented Aug 22, 2023

There still is something fishy with the project cracking happening during CI.
We would need to tackle this in Proj-Info some day.

@dawedawe
Copy link
Member Author

There still is something fishy with the project cracking happening during CI. We would need to tackle this in Proj-Info some day.

Can you reproduce that locally on your machine?
Asking because I can't. Maybe it's an issue with the build environment...

@nojaf
Copy link
Contributor

nojaf commented Aug 24, 2023

I'm bumping into ionide/proj-info#195 I think.

nojaf
nojaf approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go now!
Turns out the docs need some magic envs to use the correct System.Runtime jazz.

@nojaf nojaf merged commit 369faf8 into fsprojects:main Aug 31, 2023
@dawedawe dawedawe deleted the net8_lang_preview branch August 31, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auduchinok auduchinok auduchinok left review comments

@nojaf nojaf nojaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dawedawe @nojaf @auduchinok