Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev container #2980

Merged
merged 10 commits into from
Nov 13, 2023
Merged

Dev container #2980

merged 10 commits into from
Nov 13, 2023

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Nov 11, 2023

As a response to @gubser poor experience in #2972, I tried to set up a devcontainer.

While doing this, I did encounter some problems when only 8rc2 SDK was installed.
I needed RollForward for the test projects and of course, had to workaround dotnet/sdk#35989.

During my experiment, I updated fsdocs to the latest alpha. Even though we use a custom theme, I had to change some things for the search.

Ionide was not starting in my dev container. @Martin521 would you have any ideas what I'm still missing?

@nojaf
Copy link
Contributor Author

nojaf commented Nov 11, 2023

image

@nojaf
Copy link
Contributor Author

nojaf commented Nov 11, 2023

Turns out, that I was trying to use a local FSAC inside the container.
Works now.

@nojaf nojaf requested a review from dawedawe November 11, 2023 16:06
@dawedawe
Copy link
Member

Mmh, so far my success rate with the container is 2 out of 10 but if it can unblock others, sure, let's have it.

@Martin521
Copy link

This is how dotnet/fsharp does it:

    "customizations": {
        "vscode": {
            // Add the IDs of extensions you want installed when the container is created.
            "extensions": [
                "ms-dotnettools.csharp",
                "Ionide.Ionide-fsharp",
                "tintoy.msbuild-project-tools"
            ]
        }
    },

@nojaf
Copy link
Contributor Author

nojaf commented Nov 11, 2023

Yup, stole that part from dotnet/fsharp indeed.

@Martin521
Copy link

And wouldn't it make sense to use a .net 8 image?

@nojaf
Copy link
Contributor Author

nojaf commented Nov 11, 2023

And wouldn't it make sense to use a .net 8 image?

Yes, probably, I selected the F# option from the UI.
Might make sense to use a Dockerfile instead.

@dawedawe
Copy link
Member

Locally correctly formatted file should not be written, 1984 fails because of newline issues.
@nojaf you don't see this?

@nojaf
Copy link
Contributor Author

nojaf commented Nov 13, 2023

You mean in Windows or in the container?

@dawedawe
Copy link
Member

In the container

@nojaf
Copy link
Contributor Author

nojaf commented Nov 13, 2023

Ok, I now have it in Windows. This is a checkout-as line ending shenannigan.
Forcing lf in the test now.

Copy link
Member

@dawedawe dawedawe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much more stable for me now 👍

@nojaf nojaf merged commit 77f6444 into fsprojects:main Nov 13, 2023
5 checks passed
josh-degraw pushed a commit to josh-degraw/fantomas that referenced this pull request Nov 22, 2023
* Update fsdocs to v20 alpha

* Add devcontainer config

* Update getting started

* Build devcontainer

* cmd as one line?

* -p Init is ran as postCreateCommand cmd.

* Use docker file

* Add some handy bash functions

* Use lf in config file test

* Use explicit lf in unit test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants