Skip to content

Conversation

@nojaf
Copy link
Contributor

@nojaf nojaf commented Feb 12, 2024

I'm not sure if we really need those treat-as-warnings anymore.

@nojaf nojaf requested a review from dawedawe February 12, 2024 09:46
@dawedawe
Copy link
Member

I'm not sure if we really need those treat-as-warnings anymore.

I'm leaning more on the side to keep them, yes.

@nojaf
Copy link
Contributor Author

nojaf commented Feb 12, 2024

Don't they all produce warnings?

@dawedawe
Copy link
Member

No, some of the Ionide ones are producing Hints and Infos. But yeah, not a hill to die on.

@nojaf nojaf merged commit 85062f9 into fsprojects:main Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants