Skip to content
This repository has been archived by the owner on Jan 3, 2019. It is now read-only.

Version 1.0 of the Emacs fsharp-mode #237

Merged
25 commits merged into from
Nov 5, 2013
Merged

Version 1.0 of the Emacs fsharp-mode #237

25 commits merged into from
Nov 5, 2013

Conversation

rneatherway
Copy link
Contributor

Contains many improvements

  • Performance
  • Optional JSON output for all commands of fsautocomplete
  • Several fixes for scenarios where completion would break
  • Improved identifier parsing

I've tested this, but I'll leave the PR here for a few days if anyone wants to try it before I merge and release.

@7sharp9
Copy link
Member

7sharp9 commented Nov 5, 2013

Is any of this applicable for MonoDevelop?

On 5 Nov 2013, at 18:31, Robin Neatherway notifications@github.com wrote:

Contains many improvements

Performance
Optional JSON output for all commands of fsautocomplete
Several fixes for scenarios where completion would break
Improved identifier parsing
I've tested this, but I'll leave the PR here for a few days if anyone wants to try it before I merge and release.

You can merge this Pull Request by running

git pull https://github.com/rneatherway/fsharpbinding async-helptext
Or view, comment on, or merge it at:

#237

Commit Summary

First cut of this
Start to move logic out of the agent
fix options building
Pull all printing out to main loop
readd outputmode
Json implementation for completions+helptext
Completed ubiquitous json output
Almost completed cutover to JSON
Fix goto definition
Fix parameter info display
Fix error serialization
Fix some failing tests
Fix remaining emacs tests
Minor tidy up and test infrastructure tweaks
Pull in better parsing from Monodevelop binding
Add guard on overlay display
Merge branch 'async-helptext' of github.com:rneatherway/fsharpbinding into async-helptext
Test output update
Trial fix for issue 233
Correct typo
Stub process functions properly in emacs unit test
Remove "preempted" state and return correct helptext
Add a "rescue" to idle timer to reenable completion
Bump version numbers
Bump version numbers and change dependency order
File Changes

M FSharp.AutoComplete/Options.fs (2)
M FSharp.AutoComplete/Parser.fs (99)
M FSharp.AutoComplete/Program.fs (396)
M FSharp.AutoComplete/test/integration/OutOfRange/output.txt (10)
M FSharp.AutoComplete/test/integration/RobustCommands/completenosuchfile.txt (1)
A FSharp.AutoComplete/test/integration/Test1Json/FileTwo.fs (14)
A FSharp.AutoComplete/test/integration/Test1Json/Program.fs (15)
A FSharp.AutoComplete/test/integration/Test1Json/Script.fsx (6)
A FSharp.AutoComplete/test/integration/Test1Json/Test1.fsproj (61)
A FSharp.AutoComplete/test/integration/Test1Json/Test1JsonRunner.fsx (39)
A FSharp.AutoComplete/test/integration/Test1Json/output.txt (29)
M FSharp.AutoComplete/test/integration/Timeouts/output.txt (2)
M FSharp.AutoComplete/test/integration/runtests.sh (2)
M Makefile (3)
M emacs/fsharp-mode-completion.el (181)
M emacs/fsharp-mode-pkg.el (8)
M emacs/fsharp-mode.el (4)
M emacs/test/fsharp-mode-completion-tests.el (59)
Patch Links:

https://github.com/fsharp/fsharpbinding/pull/237.patch
https://github.com/fsharp/fsharpbinding/pull/237.diff

@rneatherway
Copy link
Contributor Author

No, it won't make any difference to Monodevelop. #233 affects Monodevelop
as well, I'm planning to handle that next.

On Tue, Nov 5, 2013 at 6:34 PM, Dave Thomas notifications@github.comwrote:

Is any of this applicable for MonoDevelop?

On 5 Nov 2013, at 18:31, Robin Neatherway notifications@github.com
wrote:

Contains many improvements

Performance
Optional JSON output for all commands of fsautocomplete
Several fixes for scenarios where completion would break
Improved identifier parsing
I've tested this, but I'll leave the PR here for a few days if anyone
wants to try it before I merge and release.

You can merge this Pull Request by running

git pull https://github.com/rneatherway/fsharpbinding async-helptext
Or view, comment on, or merge it at:

#237

Commit Summary

First cut of this
Start to move logic out of the agent
fix options building
Pull all printing out to main loop
readd outputmode
Json implementation for completions+helptext
Completed ubiquitous json output
Almost completed cutover to JSON
Fix goto definition
Fix parameter info display
Fix error serialization
Fix some failing tests
Fix remaining emacs tests
Minor tidy up and test infrastructure tweaks
Pull in better parsing from Monodevelop binding
Add guard on overlay display
Merge branch 'async-helptext' of github.com:rneatherway/fsharpbinding
into async-helptext
Test output update
Trial fix for issue 233
Correct typo
Stub process functions properly in emacs unit test
Remove "preempted" state and return correct helptext
Add a "rescue" to idle timer to reenable completion
Bump version numbers
Bump version numbers and change dependency order
File Changes

M FSharp.AutoComplete/Options.fs (2)
M FSharp.AutoComplete/Parser.fs (99)
M FSharp.AutoComplete/Program.fs (396)
M FSharp.AutoComplete/test/integration/OutOfRange/output.txt (10)
M
FSharp.AutoComplete/test/integration/RobustCommands/completenosuchfile.txt
(1)
A FSharp.AutoComplete/test/integration/Test1Json/FileTwo.fs (14)
A FSharp.AutoComplete/test/integration/Test1Json/Program.fs (15)
A FSharp.AutoComplete/test/integration/Test1Json/Script.fsx (6)
A FSharp.AutoComplete/test/integration/Test1Json/Test1.fsproj (61)
A FSharp.AutoComplete/test/integration/Test1Json/Test1JsonRunner.fsx
(39)
A FSharp.AutoComplete/test/integration/Test1Json/output.txt (29)
M FSharp.AutoComplete/test/integration/Timeouts/output.txt (2)
M FSharp.AutoComplete/test/integration/runtests.sh (2)
M Makefile (3)
M emacs/fsharp-mode-completion.el (181)
M emacs/fsharp-mode-pkg.el (8)
M emacs/fsharp-mode.el (4)
M emacs/test/fsharp-mode-completion-tests.el (59)
Patch Links:

https://github.com/fsharp/fsharpbinding/pull/237.patch
https://github.com/fsharp/fsharpbinding/pull/237.diff


Reply to this email directly or view it on GitHubhttps://github.com//pull/237#issuecomment-27799418
.

@ghost
Copy link

ghost commented Nov 5, 2013

I think this can be merged, great work. (The Travis build failed to get emacs, see here https://travis-ci.org/rneatherway/fsharpbinding/builds/13540012)

ghost pushed a commit that referenced this pull request Nov 5, 2013
Version 1.0 of the Emacs fsharp-mode
@ghost ghost merged commit 990c51f into fsprojects:master Nov 5, 2013
@ghost
Copy link

ghost commented Nov 5, 2013

I tried this out using a local install on a simple console app and did some scripting too. It seemed to work fine - I just looked for tooltips and red errors from typechecking. I also went through the OSX charting with OxyPlot here: https://gist.github.com/dsyme/7327184 and pulled up some charts.

@rneatherway
Copy link
Contributor Author

Great, thanks.

On Tue, Nov 5, 2013 at 11:06 PM, Don Syme notifications@github.com wrote:

I tried this out using a local install on a simple console app and did
some scripting too. It seemed to work fine - I just looked for tooltips and
red errors from typechecking. I also went through the OSX charting with
OxyPlot here: https://gist.github.com/dsyme/7327184 and pulled up some
charts.


Reply to this email directly or view it on GitHubhttps://github.com//pull/237#issuecomment-27822959
.

@rneatherway rneatherway deleted the async-helptext branch March 2, 2014 02:03
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants