feat: add support for user images via S3 #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
app/Http/Controllers/DashboardAdminRandomGeneratorController.php
Outdated
Show resolved
Hide resolved
app/Http/Controllers/DashboardAdminRandomGeneratorController.php
Outdated
Show resolved
Hide resolved
|
The issue (#514) suggests to add an image attribute to the user? Do you think we can get rid of this because we save the image in a given format? What do you think @TitusKirch, because you created the issue? |
I've tested the s3 upload and there were no problems with a missing certificate. |
TitusKirch
requested changes
Oct 19, 2023
app/Http/Controllers/DashboardAdminRandomGeneratorController.php
Outdated
Show resolved
Hide resolved
app/Http/Controllers/DashboardAdminRandomGeneratorController.php
Outdated
Show resolved
Hide resolved
simonostendorf
requested changes
Oct 20, 2023
|
Should the attribute "img" be added to a user to get the image uuid? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3 Upload / Zugriff hinzugefügt (creds bei Simon Anfragen und in .env hinzufügen). Für das Anzeigen der Bilder braucht curl in php ein certificate (kann ich ggf. schicken falls jemand Probleme hat). Bilder Namen beim Upload sind egal Sie werden im Hintergrund mit Vorname Nachname Course ID benannt. Entprechend greift man so auch auf die Bilder zu.