fs.url(): expose response content headers for pre-signed URLs #451
Conversation
| def sign(self, path, expiration=100, **kwargs): | ||
| """Create a signed URL representing the given path.""" | ||
| return self.url(path, expires=expiration, **kwargs) |
There was a problem hiding this comment.
s3fs uses url() for generating signed URLs, which I'm assuming is why this was originally implemented as url() in adlfs, but the top level fsspec defines actually defines sign() for this purpose:
https://github.com/fsspec/filesystem_spec/blob/ac589d8318d761ab6e198e00ba6cbd6c663732d7/fsspec/spec.py#L1536C5-L1537C59
(s3fs.sign() just calls s3fs.url())
| content_disposition=content_disposition, | ||
| content_encoding=content_encoding, | ||
| content_language=content_language, | ||
| content_type=content_type, |
There was a problem hiding this comment.
In s3fs this is supported by passing **kwargs directly into the aws/boto call, but it seems safer to be more explicit rather than passing kwargs into the generate_blob_sas.
There was a problem hiding this comment.
gcsfs.sign() also just passes **kwargs directly into the signing call, so I would not be opposed to making that change here if it's preferred
pmrowla
force-pushed
the
sign-url-content
branch
from
91484a9 to
f503d55
Compare
Exposes the fields for setting Content-Disposition, Content-Type, Content-Encoding, Content-Language response headers on a pre-signed URL. This can be useful when the desired user-facing downloaded filename is not necessarily the same as the blob path name.