Skip to content

Remove fspath from AbstractFile since broke some pyarrow #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2019
Merged

Remove fspath from AbstractFile since broke some pyarrow #105

merged 1 commit into from
Aug 13, 2019

Conversation

martindurant
Copy link
Member

Fixes #104

@martindurant martindurant merged commit ba5c6b6 into fsspec:master Aug 13, 2019
@martindurant martindurant deleted the nix_fspath branch August 13, 2019 20:32
@martindurant
Copy link
Member Author

Do you need a swift release here?

@TomAugspurger
Copy link
Collaborator

Nope. I don't think there was a release of fsspec with fspath, right?

@martindurant
Copy link
Member Author

Indeed, you are right again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AbstractBufferedFile.__fspath__ breaks dask's PyArrow.orc test
2 participants
@martindurant @TomAugspurger