Add topdown kwarg to AbstractFileSystem.walk() #1081
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new boolean kwarg
topdown
toAbstractFileSystem.walk()
. Closes #1042.I have extended the existing
test_walk
to cover bothtopdown=True
andtopdown=False
.Code produces the same output as
os.walk
which I have manually verified. I'll reproduce my test here in case it is of interest to anyone else.Test directory structure:
Test code:
Output: