Support append mode for ArrowFSWrapper #1089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can we please add a test for this in test_arrow.py? |
leoleoasd
force-pushed
the
patch-1
branch
3 times, most recently
from
366f936 to
1f47d8a
Compare
Contributor
Author
|
Hi, I've added tests. Works fine in my repo (https://github.com/leoleoasd/filesystem_spec/actions/runs/3346115981), but I need approval for running tests in PR. |
Contributor
Author
|
Hi, I would like to ask when will we release this into PyPI, is there an ETA? |
Member
|
We have a few things coming in now, so maybe within the next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support append mode for ArrowFSWrapper.
https://github.com/apache/arrow/blob/apache-arrow-1.0.0/python/pyarrow/_fs.pyx#L673
It seems that from v1.0.0, pyarrow supports
open_append_stream.