Skip to content

Simple fix for FTP LIST command returning leading 'total x' #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martindurant merged 1 commit into from
Jan 16, 2024
Merged

Simple fix for FTP LIST command returning leading 'total x' #1503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions fsspec/implementations/ftp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,15 +364,17 @@ def _mlsd2(ftp, path="."):
minfo = []
ftp.dir(path, lines.append)
for line in lines:
line = line.split()
split_line = line.split()
if len(split_line) < 9:
continue
Copy link
Member

@martindurant martindurant Jan 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would appreciate a comment here

Suggested change
continue
# not an entry, maybe something like "total: xxx"
continue

this = (
line[-1],
split_line[-1],
{
"modify": " ".join(line[5:8]),
"unix.owner": line[2],
"unix.group": line[3],
"unix.mode": line[0],
"size": line[4],
"modify": " ".join(split_line[5:8]),
"unix.owner": split_line[2],
"unix.group": split_line[3],
"unix.mode": split_line[0],
"size": split_line[4],
},
)
if "d" == this[1]["unix.mode"][0]:
Expand Down