Skip to content

Add ref to cat refs #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martindurant merged 2 commits into from
Jan 23, 2024
Merged

Add ref to cat refs #1510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29f73c4
Allow update of parquet categorical refs
martindurant Jan 19, 2024
fc7a5ce
Merge branch 'fsspec:master' into add-ref-to-cat-refs
martindurant Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fsspec/implementations/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def close_session(loop, session):
try:
sync(loop, session.close, timeout=0.1)
return
except (TimeoutError, FSTimeoutError):
except (TimeoutError, FSTimeoutError, NotImplementedError):
pass
connector = getattr(session, "_connector", None)
if connector is not None:
Expand Down
5 changes: 5 additions & 0 deletions fsspec/implementations/reference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,11 @@ def write(self, field, record, base_url=None, storage_options=None):
raws = np.full(self.record_size, np.nan, dtype="O")
for j, data in partition.items():
if isinstance(data, list):
if (
str(paths.dtype) == "category"
and data[0] not in paths.dtype.categories
):
paths = paths.add_categories(data[0])
paths[j] = data[0]
if len(data) > 1:
offsets[j] = data[1]
Expand Down