Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorder force flush condition + add 502 as retriable error #36

Closed
wants to merge 1 commit into from
Closed

reorder force flush condition + add 502 as retriable error #36

wants to merge 1 commit into from

Conversation

yan-hic
Copy link
Contributor

@yan-hic yan-hic commented Nov 20, 2017

@yan-hic
Copy link
Contributor Author

yan-hic commented Nov 20, 2017

I think the test must be adapted

@martindurant
Copy link
Member

Yes, the reordering did this, but I think that the logic now is essentially right, but that write should check for forced=True and raise the error there. Getting the tests to work is, in general, a bit of a pain, because they rely on vcrpy, which is rather flaky.

Sorry I haven't been able to dedicate any effort to this project. I hope to come back to it and clean up the several small-but-annoying issues.

@yan-hic
Copy link
Contributor Author

yan-hic commented Nov 21, 2017

Thanks @martindurant and team for Pythonic file-object support of GCS.

Why Google has not this covered yet in their client library is beyond me.
As a fyi, the arguments for it, lack of traction and perceived resistance: googleapis/google-cloud-python#3903

In the meantime I am researching how to use service accounts for GCSFS credentials as this fits a use case of mine.

@martindurant
Copy link
Member

Superseded by #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

does not handle 502 errors (returned by GCS when server is overloaded)
2 participants