Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write consistency check #103

Open
martindurant opened this issue Oct 5, 2017 · 1 comment
Open

Write consistency check #103

martindurant opened this issue Oct 5, 2017 · 1 comment

Comments

@martindurant
Copy link
Member

Counterpart to fsspec/gcsfs#20

Note that for S3, the ETag is an MD5 hash for simple uploads, and an MD5 hash of concatenated MD5 hashes in the case of multi-part uploads https://stackoverflow.com/questions/6591047/etag-definition-changed-in-amazon-s3

@TomAugspurger
Copy link
Contributor

Debugging a separate issue, I came across this same thing: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/s3.html#S3.Client.upload_part

The base64-encoded 128-bit MD5 digest of the part data. This parameter is auto-populated when using the command from the CLI. This parameted is required if object lock parameters are specified

cc @jmunroe, this would likely have helped with the partial uploads you were seeing when uploading that Zarr dataset.

API-wise, I need to get a flag like validate_write=False/True to _upload_chunk. This would probably be a parameter when creating the S3File, but I'm not sure about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants