Fix broken mkdir (#177)

* tests: add azure mkdir test for new bucket
source: dtrifiro@fac2bcf
* upath: don't use makedirs in UPath.mkdir
* upath.implementations.cloud: handle older versions of gcsfs's mkdir
* tests: remove xfails from gcsfs mkdir tests

upath/core.py

@@ -748,20 +748,19 @@ def touch(self, mode=0o666, exist_ok=True):
         self.fs.touch(self.path, truncate=not exist_ok)
 
     def mkdir(self, mode=0o777, parents=False, exist_ok=False):
-        if parents:
-            if not exist_ok and self.exists():
+        if parents and not exist_ok and self.exists():
+            raise FileExistsError(str(self))
+        try:
+            self.fs.mkdir(
+                self.path,
+                create_parents=parents,
+                mode=mode,
+            )
+        except FileExistsError:
+            if not exist_ok:
+                raise FileExistsError(str(self))
+            if not self.is_dir():
                 raise FileExistsError(str(self))
-            self.fs.makedirs(self.path, exist_ok=exist_ok)
-        else:
-            try:
-                self.fs.mkdir(
-                    self.path,
-                    create_parents=False,
-                    mode=mode,
-                )
-            except FileExistsError:
-                if not exist_ok or not self.is_dir():
-                    raise FileExistsError(str(self))
 
     def chmod(self, mode, *, follow_symlinks=True):
         raise NotImplementedError

upath/implementations/cloud.py

@@ -59,6 +59,15 @@ def relative_to(self, other, /, *_deprecated, walk_up=False):
 class GCSPath(CloudPath):
     __slots__ = ()
 
+    def mkdir(
+        self, mode: int = 0o777, parents: bool = False, exist_ok: bool = False
+    ) -> None:
+        try:
+            super().mkdir(mode=mode, parents=parents, exist_ok=exist_ok)
+        except TypeError as err:
+            if "unexpected keyword argument 'create_parents'" in str(err):
+                self.fs.mkdir(self.path)
+
 
 class S3Path(CloudPath):
     __slots__ = ()

upath/tests/implementations/test_azure.py

@@ -49,3 +49,15 @@ def test_protocol(self):
         # test all valid protocols for azure...
         protocol = self.path.protocol
         assert protocol in ["abfs", "abfss", "adl", "az"]
+
+    def test_broken_mkdir(self):
+        path = UPath(
+            "az://new-container/",
+            **self.storage_options,
+        )
+        if path.exists():
+            path.rmdir()
+        path.mkdir(parents=True, exist_ok=False)
+
+        (path / "file").write_text("foo")
+        assert path.exists()

upath/tests/implementations/test_gcs.py

@@ -5,7 +5,6 @@
 
 from ..cases import BaseTests
 from ..utils import skip_on_windows
-from ..utils import xfail_if_version
 
 
 @skip_on_windows
@@ -35,15 +34,3 @@ def test_rmdir(self):
     @pytest.mark.skip
     def test_makedirs_exist_ok_false(self):
         pass
-
-    @xfail_if_version("gcsfs", lt="2022.7.1", reason="requires gcsfs>=2022.7.1")
-    def test_mkdir(self):
-        super().test_mkdir()
-
-    @xfail_if_version("gcsfs", lt="2022.7.1", reason="requires gcsfs>=2022.7.1")
-    def test_mkdir_exists_ok_false(self):
-        super().test_mkdir_exists_ok_false()
-
-    @xfail_if_version("gcsfs", lt="2022.7.1", reason="requires gcsfs>=2022.7.1")
-    def test_mkdir_exists_ok_true(self):
-        super().test_mkdir_exists_ok_true()