upath: ensure support for __fspath__ args

fsspec · Mar 3, 2024 · ec0645f · ec0645f
1 parent ed4946b
commit ec0645f
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/upath/core.py b/upath/core.py
@@ -204,8 +204,12 @@ def __init__(
             if isinstance(args0, UPath):
                 self._storage_options = {**args0.storage_options, **storage_options}
             else:
+                if hasattr(args0, "__fspath__"):
+                    _args0 = args0.__fspath__()
+                else:
+                    _args0 = str(args0)
                 self._storage_options = type(self)._parse_storage_options(
-                    str(args0), protocol, storage_options
+                    _args0, protocol, storage_options
                 )
         else:
             self._storage_options = storage_options.copy()

diff --git a/upath/tests/test_core.py b/upath/tests/test_core.py
@@ -255,6 +255,17 @@ def test_compare_to_pathlib_path_ne():
     assert pathlib.Path("/bucket/folder") == UPath("/bucket/folder")
 
 
+def test_handle_fspath_args():
+    class X:
+        def __str__(self):
+            raise ValueError("should not be called")
+
+        def __fspath__(self):
+            return "/some/path"
+
+    assert UPath(X()).path == "/some/path"
+
+
 @pytest.mark.parametrize(
     "urlpath",
     [