Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require fsspec>=2022.1.0 #148

Merged
merged 5 commits into from
Oct 1, 2023
Merged

require fsspec>=2022.1.0 #148

merged 5 commits into from
Oct 1, 2023

Conversation

ap--
Copy link
Collaborator

@ap-- ap-- commented Sep 23, 2023 •
edited
Loading

This PR closes #141 by introducing a minimum version requirement for fsspec>=2022.1.0. I went as far back as reasonable before larger parts of the test suite started failing.

Some notes:

  • I'm xfailing the few tests that require slightly newer versions of fsspec for specific implementations. (I.e. some mkdir stuff for gcsfs<2022.7.1, or a webdav test that needs fsspec>=2022.5.0, etc...)

TODO:

  • add CI job testing against fsspec==2022.1.0
  • decide if we should:
    • fix the fs specific behavior for these xfailed tests 🚫
    • add min version requirements per implementation 🚫
    • just document them (my preferred option right now) ✔️

@ap-- ap-- force-pushed the min-fsspec-version branch 3 times, most recently from e1e9945 to 198b662 Compare September 24, 2023 20:40
@ap-- ap-- force-pushed the min-fsspec-version branch from 198b662 to 5dc2b7d Compare September 24, 2023 20:41
@ap-- ap-- marked this pull request as ready for review September 24, 2023 20:47
@ap-- ap-- merged commit 7e3836d into fsspec:main Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependencies: introduce minimum version requirement for fsspec
1 participant
@ap--