Implementation of 'local://' URI Scheme Support #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR @glesperance ❤️ please run the lint session via nox, and as soon as the fsspec pr is merged and a new fsspec release is out we can merge this. Cheers, |
|
@ap-- fsspec commit has been merged. Also added linting commit |
|
Note: waiting for the next |
ap--
requested changes
Oct 23, 2023
There was a problem hiding this comment.
Hi @glesperance
currently gcsfs==2023.9.2 is holding back installation of fsspec==2023.10.0. If you make the suggested changes, and tests succeed locally we're good to merge this.
|
|
ap--
approved these changes
Jan 25, 2024
|
Thank you again for your contribution ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the local:// URI scheme. Although it's less ubiquitous than file://, this scheme is employed by key data engineering projects like Apache Spark and Ray.io for local file handling.
Including this support broadens our software's versatility and adaptability with these projects.
[1] Spark Example -- https://spark.apache.org/docs/latest/submitting-applications.html#advanced-dependency-management:~:text=local%3A%20%2D%20a%20URI%20starting%20with%20local%3A/%20is%20expected%20to%20exist%20as%20a%20local%20file%20on%20each%20worker%20node.%20This%20means%20that%20no%20network%20IO%20will%20be%20incurred%2C%20and%20works%20well%20for%20large%20files/JARs%20that%20are%20pushed%20to%20each%20worker%2C%20or%20shared%20via%20NFS%2C%20GlusterFS%2C%20etc.
[2] Ray.io example -- https://docs.ray.io/en/latest/data/api/doc/ray.data.Dataset.write_json.html#:~:text=jsonl%22)%0A%3E%3E%3E-,ds.write_json(%22local%3A///tmp/data%22),-Time%20complexity%3A%20O
[3] Genera Github Search for "local://" -- https://github.com/search?q=local://&type=code
Note this requires fsspec/filesystem_spec#1381 to work.