-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHubPath #155
Add GitHubPath #155
Conversation
There are failing unit tests to address still, a lot of them come down to the fsspec GihubFilesystem being read only (I think 🤔 ). I'll continue to look into them but wanted to get this work out as an example. |
Thank you for the PR! To disable the write tests, you can do it similar to how we handle the http filesystem tests. Just skip the write tests: universal_pathlib/upath/tests/implementations/test_http.py Lines 37 to 75 in 7e3836d
|
Hmm and regarding the file access tests: I wonder if we should add the test files to this repo, so that the base tests can be identical. maybe under |
Co-authored-by: juftin <juftin@juftin.com> Co-authored-by: ap-- <andreas@poehlmann.io>
I took your PR and ported it to the newer UPath implementation here: 8314a65 Thanks again for your contribution 🙏 ❤️ |
This PR adds an implementation of UPath for fsspec's GithubFileSystem
Resolves #154