Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typesafety checks #212

Merged
merged 16 commits into from
Jun 15, 2024
Merged

Add typesafety checks #212

merged 16 commits into from
Jun 15, 2024

Conversation

ap--
Copy link
Collaborator

@ap-- ap-- commented Apr 1, 2024

Close #210

This PR adds typesafety checks for the UPath class interface. Tests all public attributes / method return types.

currently missing (can be done in another PR):

  • __fspath__
  • __bytes__
  • _scandir
  • link_to (on <3.12)
  • walk (on >=3.12)

Ideally, the type checks should also be done for subclasses (-> future PR).

Sorry, something went wrong.

ap-- added 8 commits April 1, 2024 00:31

Verified

This commit was signed with the committer’s verified signature.
ap-- Andreas Poehlmann

Verified

This commit was signed with the committer’s verified signature.
ap-- Andreas Poehlmann

Verified

This commit was signed with the committer’s verified signature.
ap-- Andreas Poehlmann

Verified

This commit was signed with the committer’s verified signature.
ap-- Andreas Poehlmann

Verified

This commit was signed with the committer’s verified signature.
ap-- Andreas Poehlmann

Verified

This commit was signed with the committer’s verified signature.
ap-- Andreas Poehlmann

Verified

This commit was signed with the committer’s verified signature.
ap-- Andreas Poehlmann

Verified

This commit was signed with the committer’s verified signature.
ap-- Andreas Poehlmann
@ap-- ap-- self-assigned this Apr 1, 2024
ap-- added 6 commits April 1, 2024 14:03

Verified

This commit was signed with the committer’s verified signature.
ap-- Andreas Poehlmann

Verified

This commit was signed with the committer’s verified signature.
ap-- Andreas Poehlmann
* _strip_protocol signature changes break local fs tests
* Windows URI parsing has issues

Verified

This commit was signed with the committer’s verified signature.
ap-- Andreas Poehlmann

Verified

This commit was signed with the committer’s verified signature.
ap-- Andreas Poehlmann

Verified

This commit was signed with the committer’s verified signature.
ap-- Andreas Poehlmann

Verified

This commit was signed with the committer’s verified signature.
ap-- Andreas Poehlmann
@ap-- ap-- marked this pull request as ready for review April 1, 2024 18:17
@ap-- ap-- mentioned this pull request Jun 14, 2024
16 tasks
ap-- added 2 commits June 15, 2024 11:55

Verified

This commit was signed with the committer’s verified signature. The key has expired.
ap-- Andreas Poehlmann

Verified

This commit was signed with the committer’s verified signature. The key has expired.
ap-- Andreas Poehlmann
@ap-- ap-- merged commit 14dc7ae into fsspec:main Jun 15, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static analysis of types broken in >=0.2.0
1 participant