Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #18 #23

Merged
merged 1 commit into from
Nov 27, 2022
Merged

Fix #18 #23

merged 1 commit into from
Nov 27, 2022

Conversation

newAM
Copy link
Member

@newAM newAM commented Nov 24, 2022

No description provided.

@KoviRobi
Copy link

Thank you, it works for me! [Also reassuring (for my Rust knowledge) that I started doing the same modifications in a local checkout, in removing the 'a but didn't manage to solve the SpiBus]

@newAM
Copy link
Member Author

newAM commented Nov 26, 2022

Thank you, it works for me!

Thanks for checking, I appreciate it!

I checked with my own projects and it works as well.


I'm not sure how I feel about changing impl<'a, Device, E> eh1::spi::SpiDevice for SpiDevice<'a, Device> to an implementation for the reference to avoid lifetime problems, impl<'a, Device, E> eh1::spi::SpiDevice for &'a SpiDevice<Device>, but this is for the embedded-hal 1.0.0 alpha traits, fine for now.

@newAM newAM marked this pull request as ready for review November 26, 2022 17:56
@newAM
Copy link
Member Author

newAM commented Nov 26, 2022

@geomatsi you want to take a look before I merge this?

@geomatsi
Copy link
Contributor

Hi @newAM

Feel free to merge ! I am busy with home stuff this fall, so I will not be up the task soon.

Regards,
Sergey

@newAM newAM merged commit cbe6323 into main Nov 27, 2022
@newAM newAM deleted the issue-18 branch November 27, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants